milestone 17: real deadlines, validator holes, upstream editor, trusted proxies, contract samples, badvers

specs/milestone-19.md

@@ -313,6 +313,29 @@ pinned by two tests. Restructure: `try { await onSubmit(...) } catch (error)
 { if (error instanceof ApiError) return; throw error; }`, resets after the
 try. The page's `<InlineError>` keeps rendering the mutation error as today.
 
+### Carried in from milestone 17: the stale phase-comment sweep
+
+Milestone 17 ruling 7 rewrote the "Phase 7/8" headers in three files; its
+repo-wide acceptance grep then found 24 more stale phase references in
+files its sessions did not own, recorded here for this milestone: 
+safesearch.zig:58, forward_client.zig:7, dns_cache.zig:10/:42/:435,
+cli.zig:332, filter_integration_test.zig:1391, logger.zig:178/:303,
+retention.zig:7/:137/:151, disk_monitor.zig:7, querylog_schema.zig:71,
+db.zig:272, manager.zig:292/:613/:1145, and the six repository files
+(groups_repo.zig:7, rules_repo.zig:15, sources_repo.zig:9,
+upstreams_repo.zig:7, local_repo.zig:3, clients_repo.zig:12-13). Each
+comment is rewritten to state the as-built truth it gestures at (not
+deleted, unless it says nothing beyond the phase number). Line numbers
+are hints from m17-time HEAD; re-grep before acting. Acceptance: "Phase
+7" and "Phase 8" appear in no source doc comment repo-wide; spec files
+and TECH_DEBT.md are exempt. The session owning each file in the plan
+below picks up its share; files owned by no session fall to S4.
+
+Also carried from milestone 17 (ruling 4 residual): the login log line in
+`src/web/handlers/auth.zig` prints the socket peer, which reads as
+loopback for every login behind a trusted proxy; it should print
+`request.client_addr`.
+
 ## Sessions
 
 S1-S4 run in parallel; no two sessions write the same file.