milestone 23: correct three comments the s1 review found inaccurate

This commit is contained in:
2026-08-12 22:13:49 +02:00
parent 01e455c8af
commit bb39539fdf
3 changed files with 15 additions and 9 deletions
+6 -4
View File
@@ -40,10 +40,12 @@
// does pull them in trips the guard. // does pull them in trips the guard.
// //
// Four more joined that list with the StyleX build integration: css-mediaquery, // Four more joined that list with the StyleX build integration: css-mediaquery,
// invariant, and loose-envify with js-tokens under it. They are @stylexjs/ // invariant, and loose-envify with js-tokens under it. @stylexjs/stylex
// stylex's own dependencies, they serve its compiler and not its runtime, and a // declares them, but its published runtime imports none of them — a sourcemap
// sourcemap build of a component calling stylex.props shows none of them in any // build of a component calling stylex.props shows no trace of any of the four,
// `sources` list. // so they are dead entries of the published manifest rather than code with a
// job here. css-mediaquery is the one that matters: it is BSD, and it reaching
// web/dist would force a licence decision this project has not made.
// //
// Seven more joined that list with React Aria, and the sourcemap build is again // Seven more joined that list with React Aria, and the sourcemap build is again
// what settled which: @internationalized/date, @internationalized/number, // what settled which: @internationalized/date, @internationalized/number,
+4 -3
View File
@@ -4,9 +4,10 @@ import { styles } from "./styles";
/** /**
* The StyleX compile-time transform must run in the vitest pipeline, not just * The StyleX compile-time transform must run in the vitest pipeline, not just
* in `vite build`. `runtimeInjection` is off, so an untransformed * in `vite build`. Without the plugin these tests do not fail an assertion —
* `stylex.props` call yields no class name at all — this probe fails loudly if * importing the module throws `Unexpected 'stylex.defineVars' call at runtime`
* the plugin ever drops out of the test config (milestone 23, ruling 1). * before a single case runs, which is the louder failure of the two
* (milestone 23, ruling 1).
*/ */
describe("the StyleX build integration", () => { describe("the StyleX build integration", () => {
it("compiles stylex.props into a class name", () => { it("compiles stylex.props into a class name", () => {
+5 -2
View File
@@ -172,8 +172,11 @@ export const styles = stylex.create({
overflowX: "auto", overflowX: "auto",
}, },
/** /**
* `space-y-3` became a flex column with a gap: same rendered rhythm, and it * Not a faithful port: `space-y-3` set sibling margins on a block container,
* does not depend on sibling margin collapsing. * this is a flex formatting context. StyleX has no way to write the `> * + *`
* selector that `space-y` compiles to, so the rhythm can only come from
* `gap`. Child sizing and margin behaviour differ from the Tailwind original;
* both call sites are plain vertical form stacks, where they do not.
*/ */
formCard: { formCard: {
display: "flex", display: "flex",