milestone 18: collapse duplicated infrastructure into shared listener core, crud list helper, resource shells, transport race, name and line helpers, ui modules

src/web/metrics.zig

@@ -776,7 +776,7 @@ test "the plain-DNS listener families carry every counter of both listeners" {
             .send_errors = 5,
         },
         .tcp_listener = .{
-            .accepted = 12,
+            .connections = 12,
             .rejected_at_capacity = 6,
             .rejected_at_shutdown = 7,
             .accept_errors = 8,
@@ -793,7 +793,7 @@ test "the plain-DNS listener families carry every counter of both listeners" {
     try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_udp_server_receive_errors_total 4\n"));
     try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_udp_server_send_errors_total 5\n"));
 
-    try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_tcp_server_accepted_total 12\n"));
+    try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_tcp_server_connections_total 12\n"));
     try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_tcp_server_rejected_at_capacity_total 6\n"));
     try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_tcp_server_rejected_at_shutdown_total 7\n"));
     try testing.expect(std.mem.containsAtLeast(u8, text, 1, "nxdns_tcp_server_accept_errors_total 8\n"));
@@ -822,13 +822,13 @@ test "one family covers all four listeners, summed" {
     udp4.stats.dropped_no_slot.store(2, .monotonic);
 
     var tcp6: tcp_server.TcpServer = undefined;
-    tcp6.stats = .{};
-    tcp6.stats.accepted.store(4, .monotonic);
+    tcp6.core.stats = .{};
+    tcp6.core.stats.connections.store(4, .monotonic);
 
     var tcp4: tcp_server.TcpServer = undefined;
-    tcp4.stats = .{};
-    tcp4.stats.accepted.store(5, .monotonic);
-    tcp4.stats.idle_timeouts.store(3, .monotonic);
+    tcp4.core.stats = .{};
+    tcp4.core.stats.connections.store(5, .monotonic);
+    tcp4.core.stats.idle_timeouts.store(3, .monotonic);
 
     const udp = sumListeners(udp_server.Snapshot, udp_server.UdpServer, &.{ &udp6, &udp4 }).?;
     try testing.expectEqual(@as(u64, 17), udp.received);
@@ -836,7 +836,7 @@ test "one family covers all four listeners, summed" {
     try testing.expectEqual(@as(u64, 0), udp.send_errors);
 
     const tcp = sumListeners(tcp_server.Snapshot, tcp_server.TcpServer, &.{ &tcp6, &tcp4 }).?;
-    try testing.expectEqual(@as(u64, 9), tcp.accepted);
+    try testing.expectEqual(@as(u64, 9), tcp.connections);
     try testing.expectEqual(@as(u64, 3), tcp.idle_timeouts);
 
     // No listener at all is a missing family, not a family of zeros.