milestone 18: collapse duplicated infrastructure into shared listener core, crud list helper, resource shells, transport race, name and line helpers, ui modules

src/storage/repositories/settings_repo.zig

@@ -15,38 +15,34 @@ const db = @import("../db.zig");
 const migrations = @import("../migrations.zig");
 const model = @import("../../config/model.zig");
 const context = @import("context.zig");
+const crud = @import("crud.zig");
 
 const InsertContext = context.InsertContext;
 
 /// Both strings of every pair are heap copies owned by `gpa`.
 pub fn listSettings(database: *db.Db, gpa: Allocator) db.Error!std.ArrayList(model.SettingPair) {
-    var stmt = try database.prepare("SELECT key, value FROM settings ORDER BY key");
-    defer stmt.deinit();
+    return crud.listRows(
+        model.SettingPair,
+        database,
+        gpa,
+        "SELECT key, value FROM settings ORDER BY key",
+        readSetting,
+    );
+}
 
-    var out: std.ArrayList(model.SettingPair) = .empty;
-    // `errdefer`s run in reverse: the free pass is declared last so it runs
-    // before the backing array is released.
-    errdefer out.deinit(gpa);
-    errdefer freeSettings(gpa, out.items);
-
-    while (try stmt.step()) {
-        const key = try stmt.columnTextAlloc(gpa, 0);
-        errdefer gpa.free(key);
-        const value = try stmt.columnTextAlloc(gpa, 1);
-        errdefer gpa.free(value);
-        try out.append(gpa, .{ .key = key, .value = value });
-    }
-    return out;
+fn readSetting(stmt: *db.Stmt, gpa: Allocator) db.Error!model.SettingPair {
+    const key = try stmt.columnTextAlloc(gpa, 0);
+    errdefer gpa.free(key);
+    const value = try stmt.columnTextAlloc(gpa, 1);
+    errdefer gpa.free(value);
+    return .{ .key = key, .value = value };
 }
 
 /// Only for lists `listSettings` produced. `model.toSettings` builds pairs whose
 /// `key` is a comptime string and must never be freed; that list is the caller's
 /// to release, field by field.
 pub fn freeSettings(gpa: Allocator, items: []const model.SettingPair) void {
-    for (items) |item| {
-        gpa.free(item.key);
-        gpa.free(item.value);
-    }
+    crud.freeRows(model.SettingPair, gpa, items);
 }
 
 pub fn insertSetting(database: *db.Db, item: model.SettingPair, ctx: InsertContext) db.Error!void {