milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

web/src/lib/defaultGroup.ts

@@ -0,0 +1,13 @@
+import type { Group } from "@/lib/types";
+
+/** The seeded group every client falls back to; the API forbids renaming or deleting it. */
+export const DEFAULT_GROUP_ID = 1;
+
+/**
+ * The group a form preselects. The list arrives ordered by name
+ * (groups_repo.zig), so `groups[0]` is the alphabetically first group, not the
+ * default — it is only the fallback for a list that lost the seeded group.
+ */
+export function defaultGroupId(groups: readonly Group[]): number {
+	return groups.find((group) => group.id === DEFAULT_GROUP_ID)?.id ?? groups[0]?.id ?? DEFAULT_GROUP_ID;
+}

web/src/lib/queries.ts

@@ -1,5 +1,6 @@
 import { infiniteQueryOptions, keepPreviousData, queryOptions, type QueryClient } from "@tanstack/react-query";
 import * as api from "@/lib/api";
+import { setRefreshStatus } from "@/features/blocklists/refreshStore";
 import type {
 	BlocklistInput,
 	ClientEdit,
@@ -24,11 +25,11 @@ export const queryKeys = {
 	queriesInfinite: (filter: QueriesFilter) => ["queries", "infinite", filter] as const,
 	upstreamHealth: ["upstream-health"] as const,
 	lookup: (domain: string, groupId?: number) => ["lookup", domain, groupId ?? null] as const,
+	/** Prefix of every `lookup` entry; the invalidation target after any verdict input changes. */
+	lookupAll: ["lookup"] as const,
 	groups: ["groups"] as const,
 	groupSources: (id: number) => ["groups", id, "sources"] as const,
 	blocklists: ["blocklists"] as const,
-	/** Fed only by POST /api/blocklists/update's 202 snapshot; no GET exists. */
-	blocklistSources: ["blocklists", "sources"] as const,
 	rules: ["rules"] as const,
 	localRecords: ["local-records"] as const,
 	forwardZones: ["forward-zones"] as const,
@@ -107,7 +108,7 @@ export const settingsQuery = () => queryOptions({ queryKey: queryKeys.settings,
 function invalidateGroupWorld(qc: QueryClient): Promise<unknown> {
 	return Promise.all([
 		qc.invalidateQueries({ queryKey: queryKeys.groups }),
-		qc.invalidateQueries({ queryKey: ["lookup"] }),
+		qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
 		qc.invalidateQueries({ queryKey: queryKeys.clients }),
 		qc.invalidateQueries({ queryKey: queryKeys.clientPrefixes }),
 		qc.invalidateQueries({ queryKey: queryKeys.rules }),
@@ -133,15 +134,15 @@ export const groupSourcesPutMutation = (qc: QueryClient) => ({
 	mutationFn: ({ id, sourceIds }: { id: number; sourceIds: number[] }) => api.putGroupSources(id, sourceIds),
 	onSuccess: (sourceIds: number[], { id }: { id: number; sourceIds: number[] }) => {
 		qc.setQueryData(queryKeys.groupSources(id), sourceIds);
-		return qc.invalidateQueries({ queryKey: ["lookup"] });
+		return qc.invalidateQueries({ queryKey: queryKeys.lookupAll });
 	},
 });
 
 function invalidateBlocklistWorld(qc: QueryClient): Promise<unknown> {
 	return Promise.all([
 		qc.invalidateQueries({ queryKey: queryKeys.blocklists }),
-		qc.invalidateQueries({ queryKey: ["lookup"] }),
-		qc.invalidateQueries({ queryKey: ["groups"] }),
+		qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
+		qc.invalidateQueries({ queryKey: queryKeys.groups }),
 	]);
 }
 
@@ -160,14 +161,14 @@ export const blocklistDeleteMutation = (qc: QueryClient) => ({
 	onSuccess: () => invalidateBlocklistWorld(qc),
 });
 
-/** Ruling 12: the 202 snapshot REPLACES the sources cache; counters refresh. */
+/** Ruling 12: the 202 snapshot REPLACES the refresh store; counters refresh. */
 export const blocklistsUpdateNowMutation = (qc: QueryClient) => ({
 	mutationFn: () => api.updateBlocklistsNow(),
 	onSuccess: (sources: Awaited<ReturnType<typeof api.updateBlocklistsNow>>) => {
-		qc.setQueryData(queryKeys.blocklistSources, sources);
+		setRefreshStatus(sources);
 		return Promise.all([
 			qc.invalidateQueries({ queryKey: queryKeys.blocklists }),
-			qc.invalidateQueries({ queryKey: ["lookup"] }),
+			qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
 		]);
 	},
 });
@@ -175,7 +176,7 @@ export const blocklistsUpdateNowMutation = (qc: QueryClient) => ({
 function invalidateRules(qc: QueryClient): Promise<unknown> {
 	return Promise.all([
 		qc.invalidateQueries({ queryKey: queryKeys.rules }),
-		qc.invalidateQueries({ queryKey: ["lookup"] }),
+		qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
 	]);
 }
 
@@ -192,7 +193,7 @@ export const ruleDeleteMutation = (qc: QueryClient) => ({
 function invalidateLocalRecords(qc: QueryClient): Promise<unknown> {
 	return Promise.all([
 		qc.invalidateQueries({ queryKey: queryKeys.localRecords }),
-		qc.invalidateQueries({ queryKey: ["lookup"] }),
+		qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
 	]);
 }
 
@@ -214,7 +215,7 @@ export const localRecordDeleteMutation = (qc: QueryClient) => ({
 function invalidateForwardZones(qc: QueryClient): Promise<unknown> {
 	return Promise.all([
 		qc.invalidateQueries({ queryKey: queryKeys.forwardZones }),
-		qc.invalidateQueries({ queryKey: ["lookup"] }),
+		qc.invalidateQueries({ queryKey: queryKeys.lookupAll }),
 	]);
 }