milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

web/src/features/rules/RulesPage.test.tsx

@@ -28,16 +28,17 @@ const RESPONSES: Record<string, unknown> = {
 			},
 		],
 	},
-	"/api/groups": {
-		groups: [
-			{ id: 1, name: "Default", safe_search: false },
-			{ id: 2, name: "Kids", safe_search: true },
-		],
-	},
 	"/api/version": { version: "0.0.0-test", git_commit: "0000000", zig_version: "0.16.0", uptime_seconds: 1 },
 };
 
+// The API orders groups by name, so the id-1 default is not always first.
+let groups: { id: number; name: string; safe_search: boolean }[];
+
 beforeEach(() => {
+	groups = [
+		{ id: 1, name: "Default", safe_search: false },
+		{ id: 2, name: "Kids", safe_search: true },
+	];
 	vi.stubGlobal(
 		"fetch",
 		vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
@@ -48,7 +49,7 @@ beforeEach(() => {
 					headers: { "content-type": "application/json", "Retry-After": "5" },
 				});
 			}
-			const payload = RESPONSES[url];
+			const payload = url === "/api/groups" ? { groups } : RESPONSES[url];
 			if (payload === undefined) return new Response(JSON.stringify({ error: "not stubbed" }), { status: 404 });
 			return new Response(JSON.stringify(payload), {
 				status: 200,
@@ -106,3 +107,27 @@ test("rule create shows a countdown when rate limited with Retry-After", async (
 	const alert = await screen.findByRole("alert");
 	expect(alert.textContent).toBe("Rate limited. Try again in 5s.");
 });
+
+test("the group select preselects the id-1 default, not the alphabetically first group", async () => {
+	groups = [
+		{ id: 5, name: "Attic", safe_search: false },
+		{ id: 1, name: "Default", safe_search: false },
+	];
+	renderRulesRoute();
+	await screen.findByRole("heading", { name: "Rules" });
+
+	const groupSelect = screen.getByLabelText("Group") as HTMLSelectElement;
+	expect(Array.from(groupSelect.options).map((o) => o.textContent)).toEqual(["Attic", "Default"]);
+	expect(groupSelect.value).toBe("1");
+});
+
+test("the group select falls back to the first group when the default is absent", async () => {
+	groups = [
+		{ id: 5, name: "Attic", safe_search: false },
+		{ id: 7, name: "Basement", safe_search: false },
+	];
+	renderRulesRoute();
+	await screen.findByRole("heading", { name: "Rules" });
+
+	expect((screen.getByLabelText("Group") as HTMLSelectElement).value).toBe("5");
+});