milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

web/src/features/blocklists/BlocklistForm.tsx

@@ -1,8 +1,19 @@
 import { useState, type FormEvent } from "react";
+import { ApiError } from "@/lib/api";
 import InlineError from "@/lib/InlineError";
 import type { Blocklist, BlocklistInput } from "@/lib/types";
 import { buttonClass, focusRing, inputClass, primaryButtonClass } from "@/ui/classes";
 
+/**
+ * Drops the rejection the page already renders inline below the form. Anything
+ * else is a bug in this component and must reach the console instead of dying
+ * silently in the submit handler.
+ */
+export function swallowMutationError(error: unknown): void {
+	if (error instanceof ApiError) return;
+	throw error;
+}
+
 interface BlocklistFormProps {
 	initial?: Blocklist;
 	busy: boolean;
@@ -20,13 +31,14 @@ export default function BlocklistForm({ initial, busy, error, onSubmit, onCancel
 		event.preventDefault();
 		try {
 			await onSubmit({ url: url.trim(), name: name.trim(), enabled });
-			if (initial === undefined) {
-				setUrl("");
-				setName("");
-				setEnabled(true);
-			}
-		} catch {
-			// The page renders the mutation error inline below the form.
+		} catch (error) {
+			swallowMutationError(error);
+			return;
+		}
+		if (initial === undefined) {
+			setUrl("");
+			setName("");
+			setEnabled(true);
 		}
 	}