milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

2026-08-07 20:39:27 +02:00
parent 6f67940995
commit 6c507992e4
59 changed files with 1020 additions and 382 deletions
@@ -728,8 +728,16 @@ test "every HELP line has a TYPE line and a sample, and every sample a name" {
    }
    try testing.expectEqual(helps, types);
    try testing.expectEqual(helps, samples);
-    // `nxdns_up` plus every DNS counter: the families a bare state still has.
-    try testing.expectEqual(1 + dns_stat_fields.len + 7, samples);
+    // The families a bare state still has: `nxdns_up`, every DNS counter, the
+    // query log writer's, and the diagnostic log sink's. Derived rather than
+    // counted, so a new counter in any of those structs extends the exposition
+    // and this assertion together.
+    try testing.expectEqual(
+        1 + dns_stat_fields.len +
+            @typeInfo(LoggerCounters).@"struct".fields.len +
+            @typeInfo(logging.Stats).@"struct".fields.len,
+        samples,
+    );
    // The reflective walk names the counters, so a renamed `Handler.Stats`
    // field silently renames a scraped series. Pin the ones an operator alerts
    // on by name.