milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

src/storage/retention.zig

@@ -4,7 +4,7 @@
 //!
 //! The pass touches `querylog.db` only. §3.6 walls `config.db` off from
 //! retention churn, and the `hand_edited=0` client rows of §7.2 are pruned by
-//! whatever creates them, which is Phase 7.
+//! whatever creates them, which is the client tracker (`server/clients.zig`).
 //!
 //! Nothing here retries within a pass. A failed step logs at `warn` and the
 //! next pass, a day later, does the same work again against the same data.
@@ -134,7 +134,8 @@ pub const Retention = struct {
         _ = counter.fetchAdd(delta, .monotonic);
     }
 
-    /// Daily loop, first pass immediately. Phase 7 starts it.
+    /// Daily loop, first pass immediately. The composition root starts it as a
+    /// concurrent task (`app.zig`).
     ///
     /// `boot` rather than `awake`: a box that suspends overnight must still see
     /// its day elapse.
@@ -148,8 +149,9 @@ pub const Retention = struct {
     /// with the batch, and a checkpoint or a `VACUUM` can land inside a
     /// transaction that is still open.
     ///
-    /// Retention takes `database` per call and opens nothing itself; Phase 7
-    /// opens the second connection. Isolation across the two connections is
+    /// Retention takes `database` per call and opens nothing itself; the
+    /// composition root opens the second connection with
+    /// `cli.DataDir.reopenQuerylogDb`. Isolation across the two connections is
     /// SQLite's own — WAL plus the `busy_timeout` of `db.zig`'s open options —
     /// so a pass that still loses a race sees `error.Busy` or `error.Locked`,
     /// logs at `warn`, and repeats the work on the next interval.