milestone 19: hygiene sweep - dead ecs surface, single-source constants, tls classification, frontend state hazards, docker smoke network fix

src/storage/logger.zig

@@ -41,11 +41,14 @@ pub const hidden_marker = "hidden";
 /// How long a batch waits before it re-reads the disk monitor.
 pub const gate_retry_s = 1;
 
-const max_domain_len = 253;
+/// The widths of the query log's text columns, and the single source of them:
+/// every producer that formats into one of these fields sizes its own buffer
+/// from the constant here, so nothing can format wider than the row stores.
+pub const max_domain_len = 253;
 /// RFC 5952 text of any IPv6 address, zone identifier included.
-const max_client_len = 45;
-const max_reason_len = 32;
-const max_upstream_len = 64;
+pub const max_client_len = 45;
+pub const max_reason_len = 32;
+pub const max_upstream_len = 64;
 
 /// One row on its way to `query_log`, carrying its own bytes.
 pub const Entry = struct {
@@ -175,8 +178,9 @@ pub const Logger = struct {
     /// that sees this must not expect rows.
     writer_failed: std.atomic.Value(bool),
 
-    /// `queue_buf.len` is the backpressure cap — Phase 7 passes
-    /// `cfg.query_log_buffer_max` entries. The queue holds waiting tasks in
+    /// `queue_buf.len` is the backpressure cap — the composition root
+    /// (`app.zig:311`) allocates `cfg.logging.query_log_buffer_max` entries,
+    /// which `config/validate.zig` bounds. The queue holds waiting tasks in
     /// intrusive lists, so a `Logger` must not be moved once anything has
     /// touched it.
     pub fn init(cfg: model.Logging, queue_buf: []Entry) Logger {
@@ -300,7 +304,8 @@ pub const Logger = struct {
     /// it has flushed what was left.
     ///
     /// A writer held by the disk gate keeps holding: it flushes when the disk
-    /// recovers, and Phase 7 cancels the task if it will not wait. A canceled
+    /// recovers, and the `group.cancel` that follows this call in `app.zig`
+    /// stops a writer that will not wait. A canceled
     /// writer counts the batch it holds under `queries_dropped`.
     pub fn shutdown(self: *Logger, io: std.Io) void {
         self.queue.close(io);